refactor: speed up writing model fields #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
I couldn't stand not fixing the last part. It's now much faster, takes about 12 sec. I don't see room for more improvement. |
johan-gson
reviewed
Jun 14, 2022
johan-gson
requested changes
Jun 14, 2022
edkerk
commented
Jun 15, 2022
edkerk
commented
Jun 15, 2022
johan-gson
approved these changes
Jun 15, 2022
4 tasks
…lSpeed # Conflicts: # code/io/importYaml.m
|
@haowang-bioinfo In f2d5352 I incorporated similar changes as you introduced in #392 (but not exactly the same as it wouldn't match the refactoring that I did). Can you please check that it matches the behaviour that you need? |
will look into this |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main improvements in this PR:
importYamlspeed improvement, contributing to importYaml is slow #387On my PC,
importYaml('../../model/Human-GEM.yml');tooks 248 seconds before the change and 12 seconds after the change.I hereby confirm that I have:
developas a target branch